fix: return after resolve in wipeCollectorStorage guards - #6671

Pull Request Type

• ✨ feat (New feature)
• 🐛 fix (Bug fix)
• ♻️ refactor (Code refactoring without changing behavior)
• 💄 style (UI style changes)
• 🔨 chore (Build, CI, maintenance)
• 📝 docs (Documentation updates)

Relevant Issues

resolves #6669

Description

wipeCollectorStorage called resolve() in its guards (missing hotdir, readdir error on hotdir, readdir error on storage/tmp) without returning. Execution then fell through to for (const file of files) with files undefined, throwing TypeError: files is not iterable inside the readdir callback. That is an uncaught exception, so the collector crashed at boot when the hotdir or storage/tmp was missing.

The guards now return resolve(), so boot continues.

Additional Information

The fs.rmSync call without recursive is untouched and out of scope here.

Developer Validations

• I ran yarn lint from the root of the repo & committed changes
• Relevant documentation has been updated (if applicable)
• I have tested my code functionality
• Docker build succeeds locally

Collector yarn lint:check passes and yarn test collector passes (14 suites, 408 tests).